Re: [PATCH 3/4] winegstreamer: Defer a seek to pause time if necessary.

[Zebediah Figura]

On 2/27/20 3:37 PM, Alexandre Julliard wrote:
> Zebediah Figura  writes:
> > This fixes background music in Tomb Raider II.
> > Signed-off-by: Zebediah Figura
> >
> > dlls/winegstreamer/gstdemux.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
>
> This breaks the tests:
>
> ../../../tools/runtest -q -P wine -T ../../.. -M quartz.dll -p quartz_test.exe avisplit && touch avisplit.ok
> wine: Unhandled page fault on read access to 00000000 at address 7DE2C712 (thread 0040), starting debugger...
> Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x7de2c712).
> Register dump:
>  CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b
>  EIP:7de2c712 ESP:0089fcf0 EBP:0089fd18 EFLAGS:00010206(  R- --  I   - -P- )
>  EAX:00000000 EBX:00e981e8 ECX:0089fd20 EDX:004a7afc
>  ESI:00000000 EDI:00e981f8
> Stack dump:
> 0x0089fcf0:  00000003 0089fd10 7eae1c80 0089fd20
> 0x0089fd00:  00e981e8 00000000 0089fd48 00e981e8
> 0x0089fd10:  00000000 00e981f8 0089fd48 7de279a0
> 0x0089fd20:  00e981e8 004837d0 0089fd58 0047a0bd
> 0x0089fd30:  00e981e8 00000000 0089fd60 00e981e8
> 0x0089fd40:  00000000 004837d0 0089fe18 0040fb49
> Backtrace:
> =>0 0x7de2c712 gstdemux_init_stream+0x12() [Z:\home\julliard\wine\wine\dlls\winegstreamer\gstdemux.c:1389] in winegstreamer (0x0089fd18)
>   1 0x7de279a0 filter_Pause+0x4f(iface=<couldn't compute location>) [Z:\home\julliard\wine\wine\dlls\winegstreamer..\strmbase\filter.c:336] in winegstreamer (0x0089fd48)
>   2 0x0040fb49 func_avisplit+0x2688() [Z:\home\julliard\wine\wine\dlls\quartz\tests......\include\strmif.h:1905] in quartz_test (0x0089fe18)
>   3 0x00481d1a main+0x279(argc=<is not available>, argv=<is not available>) [Z:\home\julliard\wine\wine\dlls\quartz\tests......\include\wine\test.h:548] in quartz_test (0x0089fee8)
>   4 0x004813de mainCRTStartup+0x6d() [Z:\home\julliard\wine\wine\dlls\msvcrt\crt_main.c:59] in quartz_test (0x0089ff30)
>   5 0x7b453a92 call_process_entry+0x11() in kernel32 (0x0089ff48)
>   6 0x7b453eb0 start_process+0xdf(entry=<couldn't compute location>, peb=<couldn't compute location>) [Z:\home\julliard\wine\wine\dlls\kernel32\process.c:153] in kernel32 (0x0089ffd8)
>   7 0x7b453a9e __wine_start_process+0x9() in kernel32 (0x0089ffec)
> 0x7de2c712 gstdemux_init_stream+0x12 [Z:\home\julliard\wine\wine\dlls\winegstreamer\gstdemux.c:1389] in winegstreamer: movl	0x0(%eax),%esi
> 1389	    const SourceSeeking *seeking = &filter->sources[0]->seek;

Thanks. Dumb mistake...