Re: [PATCH] uiribbon.idl: Add UIRibbonImageFromBitmapFactory coclass and more interface definitions

[Nikolay Sivov]

On 2/18/2018 1:34 AM, Fabian Maurer wrote:
> Signed-off-by: Fabian Maurer
>
> include/uiribbon.idl | 128 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 128 insertions(+)
>
> diff --git a/include/uiribbon.idl b/include/uiribbon.idl
> index 6759400be5..680ca2dd44 100644
> --- a/include/uiribbon.idl
> +++ b/include/uiribbon.idl
> @@ -64,6 +64,17 @@ typedef enum UI_COMMANDTYPE {
>      UI_COMMANDTYPE_COLORCOLLECTION,
>  } UI_COMMANDTYPE;
>
> +typedef enum UI_OWNERSHIP {
> - UI_OWNERSHIP_TRANSFER = 0,
> - UI_OWNERSHIP_COPY = 1,
>
> +} UI_OWNERSHIP;
> -
>
> +typedef enum UI_COLLECTIONCHANGE {
> - UI_COLLECTIONCHANGE_INSERT = 0,
> - UI_COLLECTIONCHANGE_REMOVE = 1,
> - UI_COLLECTIONCHANGE_REPLACE = 2,
> - UI_COLLECTIONCHANGE_RESET = 3
>
> +} UI_COLLECTIONCHANGE;

Those are v1_enum's in SDK. I think it's better to match that, even if
they are not remotable. Also UI_OWNERSHIP is defined within interface
definition, but I'm not sure how important this part is.