On 8/31/21 7:53 AM, Francois Gouget wrote:
Knowing which Windows versions have been confirmed to crash will make it easier to know whether that information is potentially obsolete if the Windows behavior changes.
Signed-off-by: Francois Gouget fgouget@codeweavers.com
I chose to put the comment on the same line as the if (0) so it is visible even with a simple source grep.
dlls/shlwapi/tests/ordinal.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/dlls/shlwapi/tests/ordinal.c b/dlls/shlwapi/tests/ordinal.c index bf43d35b1c2..15011bbdde4 100644 --- a/dlls/shlwapi/tests/ordinal.c +++ b/dlls/shlwapi/tests/ordinal.c @@ -1674,11 +1674,8 @@ static void test_SHFormatDateTimeA(void) DWORD flags; INT ret;
-if (0) -{
- /* crashes on native */
- if (0) /* crashes on Windows XP to Windows 10 20H2 */ pSHFormatDateTimeA(NULL, NULL, NULL, 0);
-}
GetLocalTime(&st); SystemTimeToFileTime(&st, &filetime);
I don't personally care where the if (0) is, but if it's going to be there, could we maybe indent the body?