On 08/06/15 06:09, Alex Henrie wrote:
2015-08-04 11:00 GMT-06:00 Jacek Caban jacek@codeweavers.com:
The third patch needs more work. It would be nice to have event helper functions more generic as in if we want to use them for yet another element type, we wouldn't need to add another argument. Maybe callers should call appropriate GetHref and GetTarget and pass strings to the helper?
I pushed a new version of patch 3 to https://github.com/alexhenrie/wine/commits/master - this version shares less code between <a> and <area>, but it will be easier to use the code in other places now. Any thoughts?
It looks much better, thanks. However, I think we shouldn't call GetHref() and GetTarget() for each event. It means that each element handler needs to check event id instead of moving that to handle_link_events (even in cost of sharing a bit less of code).
Also, please avoid moving eventid_t to mshtml_private.h. You may include htmlevent.h in files that need it.
Cheers, Jaeck