Re: [PATCH] cabinet: Turn some ERR into WARN and improved or fix messages.

[Christian Costa]

> -BOOL __cdecl FDIIsCabinet(
> > -
> >   HFDI            hfdi,
> > -
> >   INT_PTR         hf,
> > -
> >   PFDICABINETINFO pfdici)
> >
> > +BOOL __cdecl FDIIsCabinet(HFDI hfdi, INT_PTR hf, PFDICABINETINFO pfdici)
> >   {
> >     BOOL rv;
> >     FDI_Int *fdi = get_fdi_ptr( hfdi );
> > @@ -749,13 +746,13 @@ BOOL __cdecl FDIIsCabinet(
> >     if (!fdi) return FALSE;
> >       if (!hf) {
> > - ERR("(!hf)!\n");
> > - WARN("No file handle\n");
> >  SetLastError(ERROR_INVALID_**HANDLE);
> >  return FALSE;
> > }
> >  if (!pfdici) {
> > - ERR("(!pfdici)!\n");
> > - WARN("No cab info pointer\n");
> >  SetLastError(ERROR_BAD_**ARGUMENTS);
> >  return FALSE;
> > }
>
> This call already has a TRACE earlier, I don't see a point in tracing
> input parameters multiple times.
> >

Indeed. That would be better to remove them. Thanks.