Re: [PATCH 4/5] wined3d: Reject unsupported pitches in wined3d_surface_update_desc().

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-02-18 um 17:10 schrieb Matteo Bruni:
> 2015-02-18 16:44 GMT+01:00 Henri Verbeet :
> > It's a bit debatable in this case, since that depends on 
> > assumptions about callers outside of wined3d.
>
> Yes, that was my reasoning for using WARN. I can change that 
> though. I'm certainly going to move the check to 
> wined3d_texture_update_desc() as you suggest.

Fwiw, I don't have strong feelings about this, so feel free to do what
you think fits best. My thinking is that the entire patch is based on
assumptions about the client libraries. If this assumption breaks it's
worth making the resulting message more verbose than a WARN.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJU5LziAAoJEN0/YqbEcdMwD3oP/1ebOCguJuQqAVCjnGmihlVZ
8+imGRXdiRl83qvz+7g/D0j++DIpMLQdAP0GwkYsVKzkGh3lubkB8dm+/pRCB4ug
xBXE8rDDlLYhlBgBQ6pZ2RkfSdGgmEwv1kZB5HXVSkolSM4L5UyUrfXG9zUjW6ki
e4WyhYvpoJlK5wpJlndcqtGFoCocDE/3kGrIc6HvXNciY6wlRIu262anjXzNmFey
sFZyvRhLTD10wx1CipG6VUY5aAEnmOALKA8N0Jw6CBnBi2DCvKcwEtmoZAAHMo68
fUBwC+W/E8pqApfF1FNju/3ukh24S1pgWzrb7LX+iiLRBeCdhV+UswbV5iL5QPrf
v3r/wE5aL7QreP05vcnRqiSw+6/2b33rZ2vM4pdz+TOkH25DyBhUtYC0SsE4r8c1
7Vr0ofcJi/nzaEpmVdVbNtEFi0lNaxN7qA7HG7enaKYWnRooDVq/IVPfFoVuhtFl
yXdcAt2byCQbuy9rSHvqXdtLejXqdgw1My1XOpSrJ+LiVncDoZEvi0TPa5M7q3Fx
FJuZ/8jptJIxCvITbRkSCFMAQe8Nb5Ebj4Jdj77ePJrzco9Rmvf6CzyJk66P7Sw0
xq4kZTN9sp6yjdpj/wzMxEVx3J0p5wwIq7cBVvHfFIhtSdOqXpZqYqxTCqekEW2x
cOFtmivT1TluHiUYstKd
=E7V4
-----END PGP SIGNATURE-----