-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi Martell,
There are a few things in Henri's list of fixes that are still missing here:
Am 2015-02-09 um 10:28 schrieb Martell Malone:
Subject: [PATCH 2/6] dxgi: Add interface for IDXGISurface1
"include:" instead of "dxgi".
- uuid( 4ae63092-6327-4c1b-80ae-bfe12ea32b86),
You have an extra space here.
[out] HDC* hdc
HDC *hdc, or even better HDC *dc.
We avoid the Hungarian notification Microsoft once used, e.g. things like DWORD dwNumber. HDC hdc is the same kind of thing, although it's a bit of a special case.
Patch 3:
+typedef struct DXGI_OUTDUPL_MOVE_RECT {
- POINT SourcePoint;
- RECT DestinationRect;
+} DXGI_OUTDUPL_MOVE_RECT;
{ placement .
You also have FOO* bar; vs FOO *bar; issues in this patch.
[in] IUnknown* pDevice,[in] IUnknown* pWindow,[in] const DXGI_SWAP_CHAIN_DESC1* pDesc,
pStuff
The same things also occur in patches 4, 5, and 6.
Patch 4:
[size_is(count_levels)] const D3D_FEATURE_LEVEL* levels,UINT count_levels,
You are mixing count_* and *_count in patches 4, 5 and 6. For consistency's sake please make this *_count consistently.
Patch 6:
+} \ No newline at end of file
Is this intentional?