Re: WINED3D: Implement GetCreationParameters

[Stefan Dösinger]

Am Dienstag, 7. März 2006 08:50 schrieb H. Verbeet:
> On 07/03/06, Ivan Gyurdiev  wrote:
> > > - if (!pParameters) {
> > > -
> > >    ERR("(%p) : Called with a NULL pParameters\n", This);
> > > - }
> > > -
> > > - *pParameters = This->createParms;
> >
> > This is dereferencing a NULL pointer.
>
> Yes. Native d3d does that as well. The NULL pointer check there is
> purely informational.

Native D3D crashes if it's called with a NULL pointer? Are you sure that you 
shouldn't return something like D3DERR_INVALIDCALL if pParamters == NULL? 
Might be worth a test case if native really crashes.