On 10/27/21 10:22 PM, Zebediah Figura (she/her) wrote:
On 10/27/21 10:04, Rémi Bernon wrote:
Native MF aligns the NV12 planes on 16 pixels, and Greedfall expects it.
Signed-off-by: Rémi Bernon rbernon@codeweavers.com
dlls/winegstreamer/wg_parser.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
This leaves me with a lot of questions, not least of which is "can we have tests for this"? Others are:
Well, I'm not sure how to add tests? Should I add a sample video file? I think I saw one already somewhere but it doesn't look we have that many and it can grow big if we add more.
- This will change the actual height of the image, not just its layout.
Is that really correct?
Yes, as far as I could check it is the case.
- Is it really correct to change the height and not the width?
Well, the width isn't an issue with this specific game, the videos are 1920x1080 (and decoded as 1920x1088). If some other need it maybe it should.
- Is it really correct to change the reported dimensions in all
circumstances? E.g. for all formats? I'm already pretty sure that it's wrong for DirectShow...
I guess, not sure how we can tell which one is used.