On 5/20/19 1:41 PM, Dmitry Timoshkov wrote:
Jacek Caban jacek@codeweavers.com wrote:
Those changes look mostly good, but we should probably not forward QI calls in BindProtocol_QueryInterface if the protocol doesn't support aggregation.
Also I don't mind tests from patch 1, but it would be probably easier to extend test_CreateBinding(). It would also make a testing the above comment trivial.
Thanks for the review. Perhaps the patches could be accepted in current state, and I'll have a look at improving the tests according to your comments?
QueryInterface problem that I mentioned is a COM rule violation (see 3rd rule in [1]). Unless we have a prove that we should do otherwise, QueryInterface should be fixed in the same commit as StartEx. Otherwise we'd be trading one bug for another.
Thanks,
Jacek
[1] https://docs.microsoft.com/en-us/windows/desktop/com/rules-for-implementing-...