Re: [PATCH v2 1/3] msvcrt/tests: Test wcstoi64 with various Unicode digits.

[Lauri Kenttä]

On 2016-12-15 13:01, Piotr Caban wrote:
> Hi,
>
> On 12/14/16 18:18, Lauri Kenttä wrote:
> > - for (i = 0; i < sizeof(zeros) / sizeof(zeros[0]); ++i) {
> > -
> >    WCHAR tmp[] = {zeros[i] + 4, zeros[i], zeros[i] + 5, 0};
> > -
> >    res = p_wcstoi64(tmp, NULL, 0);
> > -
> >    todo_wine ok(res == 405, "with zero = U+%04X: got %d, 
> >
> > expected 405\n", zeros[i], (int)res);
> > -
> >    tmp[1] = zeros[i] + 10;
> > -
> >    res = p_wcstoi64(tmp, NULL, 0);
>
> Please change the line to:
> res = p_wcstoi64(tmp, NULL, 16);
> Currently you don't test if zeros[i]+10 is recognized as valid digit.

Right.
> Except of that the patches are looking good for me. Are these patches
> fixing any bugs? Is any application working thanks to them (I'm asking
> because of the code freeze)?

I'd assume that at least someone uses these functions, but I don't
know about any specific apps.

Should I just send v3 after 2.0 is out?