Re: wininet: Implement InternetCreateUrlA/W with test cases

[Juan Lang]

Hi James,

+/* max port num is 655936 => 6 digits */

Actually, it's 65535.  A correct comment would be appreciated ;)

+    *lpdwUrlLength += strlen("://");

You should use sizeof instead to avoid the call to strlen.  Same for other
lengths you use, like "@" and ":".

+    if (lpUrlComponents->nPort != 80 ||

This seems a bit funny.  Port 80 has no meaning for INTERNET_SCHEME_FTP or
any other non-HTTP protocol, does it?

--Juan

__________________________________ 
Yahoo! Mail - PC Magazine Editors' Choice 2005 
http://mail.yahoo.com