Mike McCormack wrote:
Martin Fuchs wrote:
"Eliminating" windowsx.h sounds like you consider this header file a bad thing. I don't think so - it provides a bunch of very usefull type safe macro definitions. (SelectFont, ListBox_SetSel, Button_SetCheck, ...)
I understand you want to eliminate some useless warnings printed by newer GCC versions. Wouldn't it be better to correct the wrong warnings of GCC instead?
I agree with this comment that we shouldn't remove the uses of these macros, but I have to disagree with them being typesafe - they aren't.
Please see my previous email for a discussion of the problem:
http://www.winehq.org/pipermail/wine-devel/2006-March/045250.html
Despite containing some useful macros, those macros are somewhat broken as they are ignorant of UNICODE, so cannot be "fixed" by simple conversion to inline functions.
Unicode isn't a problem as "void *" could simply be used, but there are other compatibility reasons why inline functions shouldn't be used.