Re: wine/ windows/scroll.c dlls/x11drv/scroll.c dl ...

[Rein Klazes]

On Sun, 27 Mar 2005 11:34:12 -0500, you wrote:
> On Fri, Mar 25, 2005 at 11:11:04AM -0600, Alexandre Julliard wrote:
> > Modified files:
> >    windows        : scroll.c 
> >    dlls/x11drv    : scroll.c 
> >    dlls/user/tests: win.c msg.c
> >
> > Log message:
> >    Rein Klazes 
> >    ScrollDC and X11DRV_SCROLLDC should scroll only pixels coming from
> >    within the visible region, clipped to the clipping region if that
> >    exists. Add the destination of pixels coming from the outside of this
> >    region to the update region. With tests that depend on this.
> >
> > Patch: http://cvs.winehq.org/patch.py?id=16854
>
> Unfortunately, this patch doesn't fix bug 1091:
>     http://bugs.winehq.org/show_bug.cgi?id=1091

If I get this correctly, your bug#1091 has to do with scrolling a window
that already has an invalidated region before the scroll. None of my
patches would affect that (making your deduction more likely true).

Attached is a patch that solves Micha's scroll problem, also discussed
under bug #1091. It also does not change the handling of an existing
invalidated region.

Changelog:

windows		: scroll.c
dlls/user/tests	: msg.c

ScrollWindow should call ScrollWindowEx with the SW_ERASE flag set. With
conformance test.

Rein.