On Saturday 17 January 2009 15:21:26 Detlef Riekenberg wrote:
On Sa, 2009-01-17 at 14:24 +0300, Vitaly Lipatov wrote:
В сообщении от 16 января 2009 Detlef Riekenberg написал(a):
On Fr, 2009-01-16 at 20:51 +0300, Vitaly Lipatov wrote:
version=`(GIT_DIR=$(TOPSRCDIR)/.git git describe HEAD2>/dev/null || echo "wine-@PACKAGE_VERSION@") | sed -n -e '$$s/(.* )/const char wine_build[] = "\1";/p'` && (echo $$version | cmp -s - $@) || echo $$version >$@ || ($(RM) $@ && exit 1)
version=`(GIT_DIR=$(TOPSRCDIR)/.git git describe HEAD2>/dev/null || echo "@PACKAGE_NAME@ @PACKAGE_VERSION@")
Your patch change also the minus to a space
Wine 1.1.13 looks more correctly than wine-1.1.13, or not?
No. Even Wine-1.1.13 is dangerous, because unix is case dependent.
Try "git describe HEAD" for reference The echo is used only as fallback, when "git describe HEAD" failed
You change the output of wine --version.
- A very high risk, that you break scripts, because of the space
- A high risk, that you break scripts, because of the different case.
You change the output of winetest
- Did you checked, that the parse script on winehq still works?
For changing "Wine" to wine", you can pipe through 'tr "W" "w"', when every supported system has a working "tr".
What about using the standard @PACKAGE_TARNAME@ which is by default normalized (spaces removed, converted to lowercase, some other unsafe characters converted) by autoconf in AC_INIT?
@PACKAGE_TARNAME@-@PACKAGE_VERSION@ is used as a base for tarball/zip/etc. by many packages.
Paul Chitescu