Re: [v5 PATCH 1/3] dwrite: Protect cached fontface list when accessed from multiple threads

[Anton Romanov]

On Tue, Aug 15, 2017 at 4:40 AM, Nikolay Sivov  wrote:
> Signed-off-by: Nikolay Sivov
>
> dlls/dwrite/dwrite_private.h | 15 ++++++++---
>  dlls/dwrite/font.c           | 30 +++++++++++++--------
>  dlls/dwrite/main.c           | 63 +++++++++++++++++++++++++++++++-------------
>  3 files changed, 74 insertions(+), 34 deletions(-)

Since apps seem to freely use fontface interfaces from multiple
threads - Isn't the following race possible?

+----------------+------------------------+-------------------------+
|       T1       |           T2           |           T3            |
+----------------+------------------------+-------------------------+
| Release        |                        |                         |
| Decrement      |                        |                         |
| == 0 -> True   |                        |                         |
|                | Query_Interface/AddRef |                         |
|                | Increment              |                         |
|                |                        | Release                 |
|                |                        | Decrement               |
| free(cached)   |                        |                         |
| factory_unlock |                        |                         |
|                |                        | use after free (cached) |
+----------------+------------------------+-------------------------+