Re: new d3d9/device.ok test always fails here, but not a regression?

[Dan Kegel]

On Sun, Jan 1, 2012 at 6:32 PM, Austin English  wrote:
> > http://bugs.winehq.org/show_bug.cgi?id=29094
> > Henri removed the regression keyword and sha1sum without comment.
> >
> > What's the reasoning there?  Is Henri saying there's
> > something wrong with my test setup (stock ubuntu),
> > or are new tests that cause 'make test' to fail not considered regressions?
> > Or something else?
>
> That _particular_ test never worked, so it's not a regression. A code
> change in d3d itself that broke a previously working test/application
> would be a valid regression.

IMHO a code change in a d3d test that broke a previously working
"make test" also counts as a regression.

The test suite is *important*.  Breakage in the test suite is not trivial.
- Dan