Re: [PATCH 2/2] bcrypt: Return STATUS_INVALID_PARAMETER when invalid flag passed to BCryptCreateHash.

[Brendan McGrath]

This patch is only changing the return value (to be consistent with 
Windows). It looks like BCRYPT_HASH_REUSABLE_FLAG is yet to be implemented?

On 5/3/19 8:05 pm, Hans Leidekker wrote:
> On Tue, 2019-03-05 at 19:52 +1100, Brendan McGrath wrote:
> > @@ -602,7 +602,7 @@ NTSTATUS WINAPI BCryptCreateHash( BCRYPT_ALG_HANDLE algorithm, BCRYPT_HASH_HANDL
> >       if (flags)
> >       {
> >           FIXME( "unimplemented flags %08x\n", flags );
> > -
> >    return STATUS_NOT_IMPLEMENTED;
> > -
> >    return STATUS_INVALID_PARAMETER;
>
> Now you're rejecting all flags while native accepts at least
> BCRYPT_HASH_REUSABLE_FLAG, according to the documentation.