On Sat, 19 Nov 2011, Francois Gouget wrote: [...]
- static const WCHAR sFmtGB[] = {'%', '.', '1', 'f', ' ', 'G', 'B', '\0'};
- static const WCHAR sFmtMB[] = {'%', '.', '1', 'f', ' ', 'M', 'B', '\0'};
- static const WCHAR sFmtkB[] = {'%', '.', '1', 'f', ' ', 'k', 'B', '\0'};
To be totally correct these should actually be 'GiB', 'MiB' and 'kiB' (the code divides by powers of 1024). However that may be too geeky for regular users so I'm not sure we want to do that. But now is probably a good time to debate this.
Here are two reference points: * On Windows winefile and explorer use 'KB' & co for the disk space although they divide by '1024'. * Nautilus uses 'kiB' & co.
Another point is that we always display the exact byte count for file sizes instead of converting it to 'KB', 'MB', etc. That actually matches winfile but seems pretty cubersome. On Windows Explorer does show file sizes as 'KB', 'MB', etc. so that's what users would expect and I think it's a place where we could follow suite.