On Mon, Sep 14, 2020 at 6:20 AM Ziqing Hui zhui@codeweavers.com wrote:
Signed-off-by: Ziqing Hui zhui@codeweavers.com
v2: Formatting.
dlls/d3dx10_43/d3dx10_43_main.c | 56 +++++++++++++++++++++++++++++++-- dlls/d3dx10_43/tests/d3dx10.c | 6 ++-- 2 files changed, 57 insertions(+), 5 deletions(-)
I have a couple of high-level comments / requests: please move the implementation out of *_main.c (async.c works I guess) and I'd prefer if you don't map the input file, rather use plain ReadFile() and close it right away.
Ideally D3DX10GetImageInfoFromMemory() should have been moved out of the file too when you implemented it, but I missed that. An additional patch moving out that function (maybe at the top of the patch series) would be nice.
Sorry for not letting you know these points before the second iteration :/