Re: [2/7] dxdiagn: Fix return and output behavior of IDxDiagContainer::EnumChildContainerNames. (try 2)

[Andrew Nguyen]

On Sun, Mar 14, 2010 at 3:05 PM, Vitaliy Margolen
 wrote:
> On 03/14/2010 11:03 AM, Andrew Nguyen wrote:
> > dlls/dxdiagn/container.c       |   15 +++++------
> >  dlls/dxdiagn/tests/container.c |   49 ++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 56 insertions(+), 8 deletions(-)
> > -
> > -
> >
> > TRACE("(%p, %u, %s, %u)\n", iface, dwIndex, debugstr_w(pwszContainer), cchContainer);
> > -
> >
> > if (NULL == pwszContainer) {
> > - TRACE("(%p, %u, %p, %u)\n", iface, dwIndex, pwszContainer, cchContainer);
> > -
> > - if (NULL == pwszContainer || 0 == cchContainer) {
> >
> > return E_INVALIDARG;
> >    }
>
> Please add printing of debugstr_w(pwszContainer) back, after sanity checks.
> It's something really useful to know.

pwszContainer is an output parameter though. Do you mean to trace the
container name after we successfully find the index in the function?
If so, I can certainly do that.