Re: [PATCH v3] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it

[Anton Romanov]

On Thu, Jan 12, 2017 at 6:52 PM, Dmitry Timoshkov  wrote:
> Anton Romanov  wrote:
> > > > +todo_wine {
> > > > - enabled = 2;
> > > > - ret = getsockopt(v4, IPPROTO_IPV6, IPV6_V6ONLY, (char*)&enabled,
> > >
> > > &len);
> > > > - ok(!ret, "getsockopt(IPV6_ONLY) failed (LastError: %d)\n",
> > >
> > > WSAGetLastError());
> > > > - ok(enabled == 1, "expected 1, got %d\n", enabled);
> > > >
> > > > +}
> > >
> > > The 'todo_wine' statements should be added only around ok() call that will
> > > fail
> > > otherwise. This applies for other places in the patch as well.
> > Those OK fail in wine.
>
> Of course, but my comment was about adding todo_wine only around the ok()
> calls and nothing else.

Well, existing tests in the same file wrap whole sections of the code
with wine_todo and I followed that.