Re: [PATCH 7/7] wined3d: Disallow disabling GLSL on core profile contexts.

[Henri Verbeet]

On 11 June 2018 at 12:05, Józef Kucia  wrote:
> static const struct wined3d_shader_backend_ops *select_shader_backend(const struct wined3d_gl_info *gl_info)
>  {
> - BOOL glsl = wined3d_settings.glslRequested && gl_info->glsl_version >= MAKEDWORD_VERSION(1, 20);
> - BOOL glsl = wined3d_settings.use_glsl && gl_info->glsl_version >= MAKEDWORD_VERSION(1, 20);
> - if (!gl_info->supported[WINED3D_GL_LEGACY_CONTEXT] && !wined3d_settings.use_glsl)
> - {
> -
>    ERR_(winediag)("Ignoring the UseGLSL registry key. "
> -
>            "GLSL is the only supported shader backend on core profile contexts. "
> -
>            "You need to explicitly set GL version to use legacy contexts.\n");

I think it's fair enough to warn people that disabling GLSL requires a
compatibility context, but note that disabling GLSL isn't exactly
supported there either.