Re: NTDLL/loader.c: Remove spaces at end of name in import_dll

[Vitaliy Margolen]

Saturday, February 18, 2006, 11:16:10 AM, Uwe Bonnes wrote:
> Changelog:
> ntdll/loader.c import_dll()
> Remove spaces at end of name retrieved with get_rva( module,
> descr->>Name )
> +/* Overwrite spaces at end of buffer with NULL */
> +inline static void skip_spaces(WCHAR *buffer, size_t len)
> +{
> - while (buffer[len -2] == (WCHAR)' ')
> - {
> -
>    buffer[len -2] = 0;
> -
>    len --;
> - }
>
> +}

This is wrong (number of errors). It should look something like this:

while (len > sizeof(WCHAR)&& buffer[len/sizeof(WCHAR) - 1] == ' ')
    {
        len -= sizeof(WCHAR);
        buffer[len/sizeof(WCHAR)] = 0;
    }

Vitaliy Margolen