Looks like in some buggy Windows versions, WOW64 returns 8, even though the size of a pointer (32-bit app) is 4.
The problem is that our Wine code itself returns 4 always (because it sizeof(DWORD) only) which is not touched by these patches. So it's a deeper problem here.
How should I proceed? Should I mark them as broken? But should I hardcode the value 8 in the broken() case? (because again, this happens only under a 32-bit app via WOW64).
Something like ok(ret <= sizeof(data) || broken(ret == 8), ...)?
On Tue, Nov 6, 2018 at 2:16 PM Marvin testbot@winehq.org wrote:
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=43969
Your paranoid android.
=== wvistau64 (32 bit Windows report) ===
comctl32: listbox.c:1155: Test failed: SendMessage(LB_DIR, DDL_DIRECTORY|DDL_EXCLUSIVE, *) failed err 18 listbox.c:1854: Test failed: got 8 listbox.c:1854: Test failed: got 8
=== wvistau64_zh_CN (32 bit Windows report) ===
comctl32: listbox.c:1155: Test failed: SendMessage(LB_DIR, DDL_DIRECTORY|DDL_EXCLUSIVE, *) failed err 18 listbox.c:1854: Test failed: got 8 listbox.c:1854: Test failed: got 8
=== wvistau64_fr (32 bit Windows report) ===
comctl32: listbox.c:1155: Test failed: SendMessage(LB_DIR, DDL_DIRECTORY|DDL_EXCLUSIVE, *) failed err 18 listbox.c:1854: Test failed: got 8 listbox.c:1854: Test failed: got 8
=== wvistau64_he (32 bit Windows report) ===
comctl32: listbox.c:1155: Test failed: SendMessage(LB_DIR, DDL_DIRECTORY|DDL_EXCLUSIVE, *) failed err 18 listbox.c:1854: Test failed: got 8 listbox.c:1854: Test failed: got 8
=== w2008s64 (32 bit Windows report) ===
comctl32: listbox.c:1854: Test failed: got 8 listbox.c:1854: Test failed: got 8
=== w7pro64 (32 bit Windows report) ===
comctl32: listbox.c:1854: Test failed: got 8 listbox.c:1854: Test failed: got 8
=== w864 (32 bit Windows report) ===
comctl32: listbox.c:1854: Test failed: got 8 listbox.c:1854: Test failed: got 8
=== w1064 (32 bit Windows report) ===
comctl32: listbox.c:1854: Test failed: got 8 listbox.c:1854: Test failed: got 8
=== wvistau64 (64 bit Windows report) ===
comctl32: listbox.c:1155: Test failed: SendMessage(LB_DIR, DDL_DIRECTORY|DDL_EXCLUSIVE, *) failed err 18