Re: [PATCH 4/4] ucrtbase: Add tests for _beginthread[ex]().

[Piotr Caban]

On 5/3/21 3:07 PM, Arkadiusz Hiler wrote:
> +static void test_thread_library_reference(char *thread_dll,
> -
>                                      enum beginthread_method beginthread_method,
> -
>                                      enum thread_exit_method exit_method)

...
> - if (exit_method != thread_exit_endthread)
> -
>    CloseHandle((HANDLE)thread_handle);

Shouldn't the CloseHandle be called depending on what function was 
called to create the thread?
> +static unsigned internal_thread_proc(void *param)
> +{
> - struct threaddll_args *args = param;
> - SetEvent(args->confirm_running);
> - WaitForSingleObject(args->past_free, 100);

It doesn't matter that much in this case but please test 
WaitForSingleObject return value. It can still give some hints if tests 
start to fail.