6 Jul
2022
6 Jul
'22
6:37 p.m.
On Wed Jul 6 17:52:44 2022 +0000, **** wrote:
Zebediah Figura replied on the mailing list:
On 7/6/22 05:08, Rémi Bernon (@rbernon) wrote: >> So yes, we could not block in IWMReader::Stop(), but that's not >> ultimately going to help anything. We do still need to wait for the >> streaming thread to stop at some point. > > Well we could then call `Stop` and wait for the WMT_STOPPED callback notification with a condition variable, releasing the filter_cs so the callbacks are free to enter it to make the thread-safety obviously correct. Unfortunately we can't release the filter CS while waiting for the thread to stop. We need to protect the whole operation.
I opened https://gitlab.winehq.org/wine/wine/-/merge_requests/393#note_3473 to make WM async reader state transitions asynchronous, so that we can then do the right thing here and wait for the callback notifications while entering the CS and avoiding the deadlock.