Re: [PATCH] Revert "include: Use the ARRAY_SIZE() macro in debug.h."

[Andre Heider]

On 18/11/2018 18:35, Henri Verbeet wrote:
> On Sun, 18 Nov 2018 at 20:56, Andre Heider  wrote:
> > wine/debug.h is a public header, and ARRAY_SIZE() is not defined for
> > external projects.
>
> The change itself seems harmless enough, but the premise seems wrong.
> Headers in include/wine are private Wine headers; why do you need (or
> want) to include wine/debug.h?

Hm, are they private? They're installed, and using wine's debug channels 
work just fine. Looking at the file, there're specific macros for 
!__WINESRC__ too, e.g. WINE_FIXME().

Apart from the debug channels, we use these too: toupperW() (unicode.h) 
wine_dlopen() (library.h), and I guess a few more.

Are the specific reasons to not expose those useful functions to 
external projects?

Regards,
Andre