Re: [PATCH 2/6] msscript.ocx: Implement IScriptControl::put_SitehWnd.

[Jacek Caban]

Hi Gabriel,

On 02.09.2020 15:01, Gabriel Ivăncescu wrote:
> Signed-off-by: Gabriel Ivăncescu
>
> dlls/msscript.ocx/msscript.c       | 7 ++++++-
>   dlls/msscript.ocx/tests/msscript.c | 2 +-
>   2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/msscript.ocx/msscript.c b/dlls/msscript.ocx/msscript.c
> index ee0cf25..f096296 100644
> --- a/dlls/msscript.ocx/msscript.c
> +++ b/dlls/msscript.ocx/msscript.c
> @@ -166,6 +166,7 @@ struct ScriptControl {
>       LONG ref;
>       IOleClientSite *site;
>       SIZEL extent;
> - LONG site_hwnd;

How about storing it as HWND instead?
>   LONG timeout;
>   VARIANT_BOOL allow_ui;
>   VARIANT_BOOL use_safe_subset;
>
> @@ -2751,8 +2752,12 @@ static HRESULT WINAPI ScriptControl_put_SitehWnd(IScriptControl *iface, LONG hwn
>   {
>       ScriptControl *This = impl_from_IScriptControl(iface);
> - FIXME("(%p)->(%x)\n", This, hwnd);
> -
>
> TRACE("(%p)->(%x)\n", This, hwnd);
> -
>
> if (hwnd && !IsWindow((HWND)hwnd))

This causes a warning on 64-bit build. You may use LongToPtr instead.

Thanks,

Jacek