Sorry, I was out Friday and Monday so I am just getting back here.
Am i reading that the general opinion is that I should rework winemp3.acm to load the external libmpg123 and just abandon the builtin mp3 support?
Or was there still something else of issue with my work?
thanks, -aric
Marcus Meissner wrote:
On Fri, Aug 14, 2009 at 12:52:48PM +0200, Michael Stefaniuc wrote:
Alexandre Julliard wrote:
Marcus Meissner marcus@jet.franken.de writes:
On Thu, Aug 13, 2009 at 09:07:29PM +0200, Alexandre Julliard wrote:
Austin English austinenglish@gmail.com writes:
On Thu, Aug 13, 2009 at 1:41 PM, Juan Langjuan.lang@gmail.com wrote: >> All the more reason to use the existing libmpg123 instead of trying to >> maintain our own version, IMO. > Aric already explained that we can't: it doesn't exist on the Mac. Not to nitpick, but if that's the reason for bundling libmpg, there are several other libraries we should bundle...
It's not the reason, as you point out the Mac is lacking a lot of things. I believe the reason we copied it was that it wasn't widely available on Linux either, because of licensing issues. If it's now included in the major distros then we should certainly consider dynamic loading.
At least on SUSE I have to patch it out due to license issues, so my builds do not have mp3 support.
What issues? The mp3 patents? That's a different problem than the
Yes. Fedora has the same problem.
original licensing issues, though of course it is also a good argument for making it a dynamic dependency.
Right; saves the vendors the effort to patch it back out of Wine.
Just for the record, I have no problem with patching it out, its just 1 commit in my local wine git tree ;)
Ciao, Marcus