On Thu, May 20, 2010 at 9:51 PM, Steven Edwards winehacker@gmail.com wrote:
On Thu, May 20, 2010 at 3:44 PM, Steven Edwards winehacker@gmail.com wrote:
I have a hacked version in the Bordeaux tree that uses sips to create icns icons and working Application bundles. If they have time, Austin or Tom can send it along for your review if your interested. The 'right' solution would be to figure out how to make them happy with png's or write a WIC encoder/filter/whatever for icns, I just don't have the time these days. Without getting off on to a long rant, I 'hacked' our version call sips on OS X to convert the images to icns.I was never able to get App bundles to want to play nice with the png images winemenubuilder spits out but it works most of the time. Since it's derived LGPL code we are happy to share, though it really is a hack and I am sure Alexandre would not want it in the tree, even for the new release.
Sorry for the double spam, I thought I did not have a copy of the code handy. Here is the hacked patch, it's quite nasty as it forks for every image is processes so it takes a while to generate the icons. There was a bit of a race condition so I further hacked it by sleeping but it got the job done. As I said, figuring out why Appbundles did not want to play nice with the png images would be great. I suspect png image AppBundle support really only works on iDevices and not full OS X and if so, we just need a better way to spitout/convert to icns images. Thanks
Everything in the .png generation looks bog standard, but maybe MacOS doesn't like our PNG comment. Try remove that ppng_set_text call in winemenubuilder's SaveIconResAsPNG and see if it helps?
-- Steven Edwards
"There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo
Damjan