Re: [PATCH] vbscript: Implemented IsNumeric

[Jacek Caban]

On 04/23/14 17:16, Jacek Caban wrote:
> On 04/23/14 02:20, Shuai Meng wrote:
> > --- a/dlls/vbscript/global.c
> > +++ b/dlls/vbscript/global.c
> > @@ -557,8 +557,41 @@ static HRESULT Global_IsNull(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VA
> >
> > static HRESULT Global_IsNumeric(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res)
> >  {
> > - FIXME("\n");
> > - return E_NOTIMPL;
> > - TRACE("(%s)\n", debugstr_variant(arg));
> > -
> > - assert(args_cnt == 1);
> > -
> > - if(res) {
> > -
> >    V_VT(res) = VT_BOOL;
>
> You can't assume that res is non-NULL.

Ignore this comment, I misread the code.

Cheers,
Jacek