Re: [PATCH] msi: Recognize remote package URLs when BaseURL is NULL

[Hans Leidekker]

On Sun, 2018-04-15 at 18:11 -0700, Anton Romanov wrote:
> Signed-off-by: Anton Romanov
>
> dlls/msi/media.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/msi/media.c b/dlls/msi/media.c
> index 0bb883b34a..f72a411410 100644
> --- a/dlls/msi/media.c
> +++ b/dlls/msi/media.c
> @@ -858,7 +858,8 @@ UINT ready_media( MSIPACKAGE *package, BOOL compressed, MSIMEDIAINFO *mi )
>      /* package should be downloaded */
>      if (compressed && GetFileAttributesW( cabinet_file ) == INVALID_FILE_ATTRIBUTES &&
> -
>        package->BaseURL && UrlIsW( package->BaseURL, URLIS_URL ))
> -
>        ((package->BaseURL && UrlIsW( package->BaseURL, URLIS_URL )) ||
> -
>         UrlIsW( cabinet_file, URLIS_URL )))
>    {
>        WCHAR temppath[MAX_PATH], *p;

cabinet_file shouldn't be a URL. Where do you see this?