[PATCH v6 2/4] shell32/tests: Add tests for IShellItemImageFactory.

[Jinoh Kang]

Signed-off-by: Jinoh Kang 
---

Notes:
    v1 -> v2: mark test broken on Windows 7
    v2 -> v3: remove erroneous todo_wine
    v3 -> v4: no changes
    v4 -> v5: test if IShellItemImageFactory::GetImage loads windowscodecs.dll
    v5 -> v6: no changes

dlls/shell32/tests/shlfolder.c | 54 ++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c
index f99045c33d5..ba2e16c138a 100644
--- a/dlls/shell32/tests/shlfolder.c
+++ b/dlls/shell32/tests/shlfolder.c
@@ -4433,6 +4433,59 @@ static void test_contextmenu(IContextMenu *menu, BOOL background)
     DestroyMenu(hmenu);
 }

+static void test_IShellItemImageFactory(void)
+{
+    HRESULT ret;
+    IShellItem *shellitem;
+    LPITEMIDLIST pidl_desktop = NULL;
+
+    if (!pSHCreateShellItem)
+    {
+        win_skip("SHCreateShellItem isn't available\n");
+        return;
+    }
+
+    ret = SHGetSpecialFolderLocation(NULL, CSIDL_DESKTOP, &pidl_desktop);
+    ok(ret == S_OK, "Got 0x%08lx\n", ret);
+    if (SUCCEEDED(ret))
+    {
+        ret = pSHCreateShellItem(NULL, NULL, pidl_desktop, &shellitem);
+        ok(SUCCEEDED(ret), "SHCreateShellItem returned %lx\n", ret);
+        if (SUCCEEDED(ret))
+        {
+            IShellItemImageFactory *siif;
+            ret = IShellItem_QueryInterface(shellitem, &IID_IShellItemImageFactory, (void **)&siif);
+            todo_wine
+            ok(ret == S_OK, "QueryInterface returned %lx\n", ret);
+            if (SUCCEEDED(ret))
+            {
+                HBITMAP hbm = NULL;
+                SIZE size = {32, 32};
+
+                ok(!GetModuleHandleA("windowscodecs.dll"), "WIC should not have already been loaded\n");
+
+                ret = IShellItemImageFactory_GetImage(siif, size, SIIGBF_BIGGERSIZEOK, &hbm);
+                todo_wine
+                ok(ret == S_OK || broken(ret == E_PENDING /* win7 */), "GetImage returned %lx\n", ret);
+                ok(FAILED(ret) == !hbm, "result = %lx but bitmap = %p\n", ret, hbm);
+
+                todo_wine
+                ok(!!GetModuleHandleA("windowscodecs.dll"), "WIC should have been loaded\n");
+
+                if (SUCCEEDED(ret) && hbm)
+                {
+                    DWORD objtype = GetObjectType(hbm);
+                    ok(objtype == OBJ_BITMAP, "Expected type OBJ_BITMAP, got %lu\n", objtype);
+                    DeleteObject(hbm);
+                }
+                IShellItemImageFactory_Release(siif);
+            }
+            IShellItem_Release(shellitem);
+        }
+        ILFree(pidl_desktop);
+    }
+}
+
 static void test_GetUIObject(void)
 {
     IShellFolder *psf_desktop;
@@ -5385,6 +5438,7 @@ START_TEST(shlfolder)
     test_SHCreateShellItemArray();
     test_ShellItemArrayEnumItems();
     test_desktop_IPersist();
+    test_IShellItemImageFactory();
     test_GetUIObject();
     test_CreateViewObject_contextmenu();
     test_SHSimpleIDListFromPath();