2016-01-08 2:14 GMT+01:00 Henri Verbeet hverbeet@gmail.com:
On 8 January 2016 at 01:55, Matteo Bruni matteo.mystral@gmail.com wrote:
+static inline struct d3dx9_animation_controller *impl_from_ID3DXAnimationController(ID3DXAnimationController *iface)
Not a big deal but I think it's better to avoid the "inline" here, it's unnecessary in this case since the function isn't in a .h file.
I don't necessarily disagree, but just about every other impl_from_*() implementation does have "inline".
+static HRESULT WINAPI d3dx9_animation_controller_SetTrackPosition(ID3DXAnimationController *iface,
UINT track, double position)+{
- FIXME("iface %p, track %u, position %g stub.\n", iface, track, position);
It doesn't seem a good choice to me to use %g instead of %f for double parameters.
What you want is %a, but that's C99. But yeah, just stick with %e and an appropriate precision specifier.
+static HRESULT WINAPI d3dx9_animation_controller_SetTrackEnable(ID3DXAnimationController *iface,
UINT track, BOOL enable)+{
- FIXME("iface %p, track %u, enable %u stub.\n", iface, track, enable);
BOOL is defined as long i.e. signed.
That doesn't necessarily mean it makes more sense to print it like that though. Personally I'd go with %#x.
Those are all good points. WRT the precision for the %e specifier, the correct value for double (to avoid losing precision) would be ".16". That's a lot of digits but nevertheless it seems preferable to discarding potentially valuable information.