Re: mshtml: Add IHTMLXMLHttpRequest::responseXML() method implementation. (try 2)

[Jacek Caban]

Hi Zhenbo,

On 11/04/15 15:34, Zhenbo Li wrote:
> Try 2:
> Thanks Nikolay & Jacek
> Making the ERR() less verbose
> Signed-off-by: Zhenbo Li
>
> dlls/mshtml/tests/xmlhttprequest.c | 41 +++++++++++++++++++++++++++++
>  dlls/mshtml/xmlhttprequest.c       | 53
> ++++++++++++++++++++++++++++++++++++--
>  2 files changed, 92 insertions(+), 2 deletions(-)

Sorry for the delay, I was waiting for wine-devel discussion to come to
conclusion, but failed to reply when it did. It would be nice to move it
from pending state, although I'm not sure we can do that before code freeze.

+
+    hres = IXMLDOMDocument_loadXML(xmldoc, str, &vbool);
+    SysFreeString(str);
+    if(hres != S_OK || vbool != VARIANT_TRUE) {
+        ERR("loadXML failed: %08x\n", hres);
+        IXMLDOMDocument_Release(xmldoc);
+        return hres;
+    }

Note that if loadXML fails, you will return S_FALSE here, which I'm sure is desired. It would be nice to have a test for that.

Also discussion with Nikolay convinced me that assert() would be a better way to handle IObjectSafety errors.

Thanks,
Jacek