Re: [PATCH 3/3] ddraw/tests: Skip caps test if certain caps not present.

[Jeff Smith]

On Thu, Jan 23, 2020 at 2:40 PM Jeff Smith  wrote:
> On Thu, Jan 23, 2020 at 12:27 PM Stefan Dösinger
>  wrote:
> > Am 23.01.20 um 18:33 schrieb Jeff Smith:
> > > - if (hal_caps.ddsCaps.dwCaps && (~hal_caps.ddsCaps.dwCaps & caps_always))
> > > - {
> > > -
> > >    skip("Failed to find sufficient hardware caps, skipping test.\n");
> > > -
> > >    IDirectDraw_Release(ddraw);
> > > -
> > >    return;
> > > - }
> >
> > On which machine do you get test failures otherwise? Can you test
> > https://source.winehq.org/patches/data/176979 and see if that helps too?
> > Patch 176980 may be relevant too.
>
> IIRC, on the testbot machine using the "WMware SVGA II" driver, the
> HAL caps include
>     DDSCAPS_FLIP, DDSCAPS_OFFSCREENPLAIN, DDSCAPS_PRIMARYSURFACE
> but not
>     DDSCAPS_TEXTURE, DDSCAPS_ZBUFFER, DDSCAPS_MIPMAP
>
> I don't have a box set up that reports lacking these caps.

Hi Stefan,

Well, it seems I cannot test that machine directly (I guess it's
available only for the 'daily' build),
but I really believe this is just a case of the driver being very
limited in capability.

Thanks,
Jeff