Re: [PATCH] gdi32: Remove no-op abs(3) call.

[Huw Davies]

On Tue, Feb 16, 2016 at 01:55:34PM -0700, Charles Davis wrote:
> Signed-off-by: Charles Davis
>
> dlls/gdi32/pen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/gdi32/pen.c b/dlls/gdi32/pen.c
> index 2ae2f2b..6793934 100644
> --- a/dlls/gdi32/pen.c
> +++ b/dlls/gdi32/pen.c
> @@ -195,7 +195,7 @@ HPEN WINAPI ExtCreatePen( DWORD style, DWORD width,
>      if (logbrush.lbStyle == BS_DIBPATTERN) logbrush.lbStyle = BS_DIBPATTERNPT;
>  penPtr->logpen.elpPenStyle = style;
> - penPtr->logpen.elpWidth = abs(width);
> - penPtr->logpen.elpWidth = width;
> penPtr->logpen.elpBrushStyle = logbrush.lbStyle;
> penPtr->logpen.elpColor = logbrush.lbColor;
> penPtr->logpen.elpHatch = brush->lbHatch;

This breaks a test:

../../../tools/runtest -q -P wine -T ../../.. -M gdi32.dll -p gdi32_test.exe.so pen && touch pen.ok
pen.c:440: Test failed: expected 123, got ffffff85

width is actually treated as signed.

Huw.