Andrew Fenn wrote:
I just submitted a patch to wine patches (Started implementing the xinput library for xbox 360 joystick support ) and I believe patch watcher failed for a few reasons.
- Although it applied my patch it didn't build it as
./tools/make_makefiles isn't called so it isn't built?
I think make_makefiles is called: http://code.google.com/p/winezeug/source/browse/trunk/patchwatcher/patchwatc... Maybe I should make the log more verbose...
- Patch watcher seems to fail because of another patch, perhaps the
latest known good build should be tested if the patch fails and then compared with the first failed attempt?
We don't accumulate patches. There was no other patch active when yours was tested. This was probably just a rare failure of a slightly flaky test. When I verify that tests are flaky, I add them to a blacklist. You just got unlucky, I think. Once you figure out why your patch didn't trigger your stuff to be built, resubmit... - Dan