Re: [comctl32] implement header callback support (HDN_GETDISPINFO notification)

[Raphael]

Hi,

Try 2

Changelog:
 - implement implement header callback support (HDN_GETDISPINFO notification):
 - better factorisation
 - unicodiness fixes

On Tuesday 15 November 2005 03:02, Vitaliy Margolen wrote:
> Monday, November 14, 2005, 6:31:29 PM, Raphael wrote:
> > +HEADER_SendHeaderDispInfoNotify(HWND hwnd, INT iItem, INT mask,
> > NMHDDISPINFOW* pDispInfo)
>
> You can't do this. Please respect unicodiness of the control. See other
> controls (listvew, treeview for examples).

expect this patch is correct for unicodiness 
(i haven't see the problem as headers never used NotifyFormat switches before)
> > -
> >    else if (lpItem->pszText == LPSTR_TEXTCALLBACKW) /* covers ==
> >
> > TEXTCALLBACKA too */ -            phdi->>pszText = LPSTR_TEXTCALLBACKW;
> > -
> >    else if (lpItem->pszText == LPSTR_TEXTCALLBACKW) { /* covers ==
> >
> > TEXTCALLBACKA too */ +         /*phdi->>pszText = LPSTR_TEXTCALLBACKW;*/
> > -
> >   NMHDDISPINFOW dispInfo;
> > -
> >   HEADER_SendHeaderDispInfoNotify(hwnd, nItem, HDI_TEXT,
> >
> > &dispInfo);
>
> This requires a test. I don't think native sends notify to the app for
> HDM_GETITEM.

This is the meaning of GETDISPINFO header callbacks as seen in documentation:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pla...
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pla...
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pla...

Thx for comments
> Vitaliy

Regards,
Raphael