On Thursday, 1 August 2013 12:19 AM, Vincent Povirk wrote:
The problem is there are situations where patches are never reviewed and no one is told why.
After some thought, it occurred to me that the said patches are being reviewed; they just never have their status altered.
So, one possible way to work through this issue is to split the meaning of 'Pending' into two parts.
'Pending' currently describes two actions for patches:
* The patch is not obviously correct at first glance. Making a more convincing argument, preferably in the form of a test case, may help. * Waiting for feedback from the main developer in that area.
We could have: * P1: "The patch is not obviously correct at first glance. [Revision needed / Anything equivalent to go here]." * P2: "Waiting for feedback from the main developer in that area."
Changing the patch status would then give an indication of action to be taken by the developer. Of course, while these ideas are likely to provide greater clarity, the downside is that there is more work involved for the maintainer.