On 5/6/2021 6:11 PM, Jefferson Carpenter wrote:
On 5/6/2021 2:12 PM, Nikolay Sivov wrote:
Maybe, but there's many more methods that modify the tree.
Yes, in fact I missed some. I could write a test that sets domdoc output, then calls all of them - to figure out which ones would need to have this check.
This is what I was talking about by testing "all of" the DOMDocument methods and seeing which ones get disabled when it is an active mxwriter destination.
These are only the IXMLDOMNode methods - not any of the additional IXMLDOMElement or IXMLDOMDocument methods - but they already show some interesting behavior, e.g. what transformNode does that is not documented on MSDN.
I would want to also do this for at least IXMLDOMElement and IXMLDOMDocument.
Next version of this patch is planned to include this (with todo_wine added for the remaining unimplemented cases) - unless you don't think it's a good idea, in which case I won't include it.
Thanks, Jefferson