Re: [PATCH vkd3d 6/6] vkd3d-shader: Implement hlsl_note().

[Zebediah Figura (she/her)]

On 2/18/21 5:47 PM, Matteo Bruni wrote:
> Signed-off-by: Matteo Bruni
>
> The patch is fine. While testing this I realized that we currently use
> preprocessed source locations, which aren't necessarily correct for
> the original source. Clearly it isn't a big deal or even worth fixing
> necessarily, but I wonder how that is usually handled by other
> compilers. Do their preprocessors keep location info for each
> preprocessed token?

I noticed that too, but I never looked at any other compiler sources. I 
think that gcc saves columns in its line directives as well, which would 
presumably provide enough information to reconstruct the exact location, 
but obviously the HLSL preprocessor doesn't do that. We may be forced to 
pass a token stream internally.