Hi Gerald,
On 03/07/12 23:35, Gerald Pfeifer wrote:
I noticed we return in this case, without initializing this variable. Visual inspection indicates we do not seem to access the variable in this error case, but a) better safe than sorry, and b) GCC 4.8 currently warns about it.
Not sure URLPOLICY_DISALLOW is the best return value, open for better alternatives.
I generally don't think this patch makes things any better (or worse). If we return an error, the caller should not expect this value to be sane. What's the GCC 4.8 warning?
Jacek