Re: [PATCH v4 1/2] oleaut32/tests: Add tests for ITypeInfo::GetDllEntry()

[Huw Davies]

On Wed, Jun 10, 2020 at 05:33:38PM +0800, Porot Mo wrote:
> Signed-off-by: Porot Mo
>
> v3: check returned dllname, split tests and fix
> v4: add todo_wine to pass tests
>
> dlls/oleaut32/tests/test_reg.idl | 13 ++++++++++
>  dlls/oleaut32/tests/typelib.c    | 53 ++++++++++++++++++++++++++++++++++++++--
>  2 files changed, 64 insertions(+), 2 deletions(-)
> -
> - /* correct memberid -- correct invkind */
> - hr = ITypeInfo_GetDllEntry(pTypeInfo, 0x60000000, INVOKE_PROPERTYGET, &bstrDllName, &bstrName, &ordinal);
> - ok_ole_success(hr, ITypeInfo_GetDllEntry);
> - ok(!lstrcmpW(bstrDllName, wszTestDll), "got %s\n", wine_dbgstr_w(bstrDllName));
> - ok(bstrName == NULL, "got %s\n", wine_dbgstr_w(bstrName));
> - ok(ordinal == 1, "got ordinal: %04x\n", ordinal);

You're leaking bstrDllName here.  I've sent in a new version
with this fixed.  I've also taken the opportunity to tidy
up some of the existing code.

Thanks,
Huw.