Re: [PATCH 4/5] d3dcompiler: Store derefs as an offset to a variable.

[Matteo Bruni]

On Wed, May 20, 2020 at 12:21 AM Zebediah Figura
 wrote:
> For that kind of splitting, it doesn't. However, it can help:
> - splitting constructors, where the type doesn't need to change, and we
>
> can replace the HLSL_IR_CONSTRUCTOR instruction with HLSL_IR_LOAD;
> -
>
> constant folding, where we can replace HLSL_IR_EXPR with HLSL_IR_CONSTANT;
> -
>
> function inlining, where we replace HLSL_IR_CALL with HLSL_IR_LOAD of
>
> a synthetic return variable.

Okay, I see. I think it might be acceptable, although I don't feel
like it's going to help too much. With the usual caveats...

I guess I'm saying: I'd go ahead without the union, until it becomes
clear that it would actually help significantly.