9 Jun
2022
9 Jun
'22
7:22 p.m.
Matteo Bruni (@Mystral) commented about dlls/d3dx10_43/tests/d3dx10.c:
- }while(0)
+#define CHECK_EXPECT(func) \
- do { \
CHECK_EXPECT2(func); \expect_ ## func = FALSE; \- }while(0)
+#define CHECK_CALLED(func) \
- do { \
ok(called_ ## func, "expected " #func "\n"); \expect_ ## func = called_ ## func = FALSE; \- }while(0)
+DEFINE_EXPECT(D3DX10ThreadPump_AddWorkItem);
I'm not super thrilled by this kind of heavy macro usage, but I guess there's many more tests to come and I see that similar macros are used in many more places, so I'll shut up :sweat_smile:
Can you fix up the formatting please? I think we want to consistently have no spaces around the '##' operator and a space between the '}' and the while keyword.
Unfortunately I can't update your merge request myself at the moment (going to request access in a second) otherwise I'd have fixed it up myself, or at least dropped the final patch and approved the rest.