Re: [PATCH vkd3d 4/8] vkd3d-shader/hlsl: Prepare to swap switch order on fold_constants().

[Zebediah Figura (she/her)]

On 1/7/22 03:31, Giovanni Mascellani wrote:
> Hi,
>
> under the same "code clean at all times" rule of my last email, I don't 
> think we want to have this intermediate state. From what I've seen, 
> usually boilerplate code is to be added with the first "useful" code 
> that uses it (and removed with the last "useful" code that uses it).
>
> Personally I'd also say that you can just convert the code in just one 
> commit, without creating a commit for each single operation, which would 
> let you drop the "goto fallback" trick. After all it's just four 
> operations, not that hard to check. But I'm not sure others will agree 
> with this.

FWIW, I'd agree with this. Semantically it's one change, and it's clear 
enough what's being done.