Re: [PATCH vkd3d 2/5] vkd3d-shader: Fold addition and multiplication of uint constants.

[Matteo Bruni]

On Tue, Mar 16, 2021 at 10:33 PM Zebediah Figura
 wrote:
> Signed-off-by: Zebediah Figura
>
> libs/vkd3d-shader/hlsl_codegen.c | 102 +++++++++++++++++++++++++++++++
>  1 file changed, 102 insertions(+)

I have a tiny nitpick:
> diff --git a/libs/vkd3d-shader/hlsl_codegen.c b/libs/vkd3d-shader/hlsl_codegen.c
> index 39984702..c8d8d17f 100644
> --- a/libs/vkd3d-shader/hlsl_codegen.c
> +++ b/libs/vkd3d-shader/hlsl_codegen.c
> @@ -20,6 +20,106 @@
>
> #include "hlsl.h"
>
> +static bool transform_ir(struct hlsl_ctx *ctx, bool (*func)(struct hlsl_ctx *ctx, struct hlsl_ir_node *, void *),
> -
>    struct list *instrs, void *context)
>
> +{

The "func" callback parameters in the declaration should probably
either be all named or all unnamed.