Re: [PATCH v2 3/4] mf: Generate missing MEStreamSinkPaused event in the sample grabber.

[Nikolay Sivov]

On 5/28/21 10:50 AM, Giovanni Mascellani wrote:
> diff --git a/dlls/mf/samplegrabber.c b/dlls/mf/samplegrabber.c
> index f60ce2a8433..815e3f60feb 100644
> --- a/dlls/mf/samplegrabber.c
> +++ b/dlls/mf/samplegrabber.c
> @@ -1171,6 +1171,8 @@ static HRESULT WINAPI sample_grabber_clock_sink_OnClockPause(IMFClockStateSink *
>  TRACE("%p, %s.\n", iface, debugstr_time(systime));
>
> - IMFStreamSink_QueueEvent(&grabber->IMFStreamSink_iface, MEStreamSinkPaused, &GUID_NULL, S_OK, NULL);
> - return IMFSampleGrabberSinkCallback_OnClockPause(sample_grabber_get_callback(grabber), systime);
>
> }

This is incomplete, for several reasons. Pause when stopped is an
invalid transition; pause when already paused should not generate an event.